Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making TreeRegionJoin consistent with ShuffleRegionJoin #1515

Merged
merged 1 commit into from
May 5, 2017
Merged

Making TreeRegionJoin consistent with ShuffleRegionJoin #1515

merged 1 commit into from
May 5, 2017

Conversation

devin-petersohn
Copy link
Member

Resolves #1514

@devin-petersohn
Copy link
Member Author

This is just something I found along the way. I split it out of #1324 because this has a chance to potentially break some things.

@coveralls
Copy link

coveralls commented May 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 81.783% when pulling 1f7c9b4 on devin-petersohn:issue#1514TreeRegionJoinRefactor into 36d8e0b on bigdatagenomics:master.

fnothaft
fnothaft approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@fnothaft fnothaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @devin-petersohn! LGTM.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/1973/
Test PASSed.

@fnothaft fnothaft merged commit c77c600 into bigdatagenomics:master May 5, 2017
@fnothaft
Copy link
Member

fnothaft commented May 5, 2017

Merged! Thanks @devin-petersohn!

@devin-petersohn
Copy link
Member Author

Thanks @fnothaft!

@heuermh heuermh added this to the 0.23.0 milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnothaft fnothaft fnothaft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@devin-petersohn @coveralls @AmplabJenkins @fnothaft @heuermh